Skip to content

rename connection pool configuration #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2020
Merged

rename connection pool configuration #288

merged 2 commits into from
Jul 31, 2020

Conversation

artemredkin
Copy link
Collaborator

Rename pool configuration type and property to ConnectionPool

Motivation:
HTTPConfiguration.poolConfiguration is redundant and does not make clear what pool are we talking about.

Modifications:
Rename property and type to ConnectionPool

Result:
Closes #286

@artemredkin artemredkin added this to the 1.2.0 milestone Jul 30, 2020
@artemredkin artemredkin requested review from weissi and Lukasa July 30, 2020 10:32
@artemredkin
Copy link
Collaborator Author

Error:

ERROR:  Error installing jazzy:
	cocoapods-downloader requires Ruby version >= 2.3.3.

@artemredkin
Copy link
Collaborator Author

@swift-server-bot test this please

@artemredkin
Copy link
Collaborator Author

Same error in 5.1, @tomerd could you help with that?

@tomerd
Copy link
Contributor

tomerd commented Jul 31, 2020

@artemredkin I think we can do something like apple/swift-nio-ssl#234

Lukasa
Lukasa approved these changes Jul 31, 2020
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we can get the CI fixed.

@artemredkin artemredkin merged commit c9a9bf0 into swift-server:master Jul 31, 2020
@artemredkin artemredkin deleted the rename_pool_conf_type branch July 31, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@weissi weissi Awaiting requested review from weissi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Redundant naming in poolConfiguration
3 participants
@artemredkin @tomerd @Lukasa